teakivy / teaks-tweaks

150+ Toggleable Tweaks & Features including Vanilla Tweaks as a plugin, and more!
https://modrinth.com/plugin/teaks-tweaks
MIT License
24 stars 16 forks source link

Screaming goat mob head drop problems #103

Closed EladJenkins closed 2 months ago

EladJenkins commented 2 months ago

In the "More Mob Heads" pack, the screaming goat head does not drop with the chance as configured in mob_heads.json. By default, the drop chance is 100%; however, it appears that the drop chance is actually used is the one for regular goats. Additionally, when a screaming goat head does drop, the note block sound associated with it is entity.goat.ambient, when it should be entity.goat.screaming.prepare_ram as defined in the original Vanilla Tweaks data pack.

Steps to reproduce the behavior:

  1. Create fresh Paper 1.21.1 server with default configuration.
  2. Install Teak's Tweaks 1.11.2-beta.
  3. In game, summon a screaming goat with command /summon minecraft:goat ~ ~ ~ {IsScreamingGoat:true}.
  4. Kill goat. Most likely, a head will not drop.
  5. Shut down server.
  6. In the plugin's mob_heads.json file, change goat.chance value to 1.0 and goat.looting_bonus value to 0.0.
  7. Start server.
  8. Summon screaming goat and kill.
  9. Head will drop.
  10. Using the command /paper dumpitem, confirm that although the name and texture are for a screaming goat, the associated note block sound is entity.goat.ambient.

Expected behavior Screaming goat head drop chance should be respected, and the resulting head should have an associated note block sound of entity.goat.screaming.prepare_ram.

teakivy commented 2 months ago

Fixed in the next version.