search

teakivy / teaks-tweaks

150+ Toggleable Tweaks & Features including Vanilla Tweaks as a plugin, and more!
https://modrinth.com/plugin/teaks-tweaks
MIT License
24 stars 16 forks source link

Added Russian translation, microfix "drops-water-level" #129

Closed Vinellon closed 1 week ago

Vinellon commented 2 weeks ago

The fix is that previously, with "drops-water-level: true", the water level did not fall, but with "drops-water-level: false", on the contrary, it fell)

Loudbooks commented 2 weeks ago

This should probably be multiple pull requests...

Vinellon commented 2 weeks ago

There's probably a lot more that I missed here. Quality is sub-par. Functionality not tested, only reviewed for code quality.

Placeholder API support should be moved a new PR. Russian translation is already enough for one, let alone bug fixes and and implementation with another plugin.

Well, when checking on my server, everything seemed to work without problems (both with online and offline uuids). Honestly I don't know much about github, but as I understand I need to rollback the commit with PAPI, and open pull request with this change through a new branch?

Loudbooks commented 2 weeks ago

@Vinellon I meant I didn't test it. It should be tested both with Placeholder and without.

And yes, what you said is in theory one way to do that.

Vinellon commented 2 weeks ago

If I understood correctly, in case PlaceholderAPI will not be installed on the server, it should not affect the plugin (of course, the placeholder itself will not work).

Vinellon commented 2 weeks ago

So, I canceled the commit with placeholder, now there is only translation and microfix (I don't think it should be removed, because it's literally 2 characters).

Also, I try to fix everything you've written about here