search

teal-language / cyan

The Teal build system and project manager
MIT License
62 stars 6 forks source link

[wip] test `next-compat-api` branch for tl #46

Closed hishamhm closed 1 month ago

hishamhm commented 2 months ago

This does pass CI but it's not there yet!

I'm still fixing up this branch locally to make bin/local-cyan build run correctly with the next-compat-api branch of Teal.

hishamhm commented 2 months ago

@euclidianAce Please give this branch a look! Using this and next-compat-api, I got bin/local-cyan build -u to check without errors. If you give me the thumbs-up that this looks like a good base to work on, I will merge next-compat-api into next, so you can take this branch as a base to make Cyan next-ready. How does that sound?

hishamhm commented 2 months ago

(for clarity: this is marked as draft because this is not intended to merge as-is, but it is ready for review)

hishamhm commented 2 months ago

Also pinging @vlaaad from https://github.com/defold/extension-teal since that also uses Cyan — using branches next-compat-api from https://github.com/teal-language/tl and this PR's branch from Cyan, I hope the Defold extension works with minimal-to-no-changes (you might need to set feat_arity to "off" in tlconfig.lua or whichever other way the extension uses to set compiler options, because of this incompatible change). Let me know if you have any issues or questions! (Of course, positive feedback in case things works is also extremely welcome :) )

hishamhm commented 1 month ago

@euclidianAce Thank you for going through this! Your feedback gave me confidence to merge next-compat-api into next, so you can use the real next as a base moving forward!

euclidianAce commented 1 month ago

I've pushed my local branch tl-next which has these changes (and more other features I was working on). Thanks for the initiative and feedback!