search

teal-language / teal-language-server

A language server for Teal, a typed dialect of Lua
MIT License
81 stars 9 forks source link

build: add makefile and rebuild #11

Closed lewis6991 closed 1 year ago

lewis6991 commented 1 year ago

@euclidianAce are you able to review this?

euclidianAce commented 1 year ago

I'm not a huge fan of adding a make dependency. I've prototyped a build hook here to prompt the user to download the lfs and dkjson .d.tl files. I did cherry pick the .gitattributes commit though.

Thanks for pointing out the annoyance of having to manually set up the type dependencies though!

lewis6991 commented 1 year ago

Dependency on make? You know that's just standard tooling included in basically every unix distro? It's also optional here and just automates some stuff.

euclidianAce commented 1 year ago

Okay, dependency is a strong word, but I do want to be cautious of catering to a unix environment since I do have to use a windows machine occasionally, and don't want to limit these kind of niceties to just unix.

lewis6991 commented 1 year ago

Hmm fair enough.

I'm not sure adding a 200loc script that depends on private API's in cyan (which is basically alpha at this point) is a better approach. There must be some other cross platform solution. I'm surprised make isn't available in some form on windows.

lewis6991 commented 1 year ago

Will this not suffice? https://stackoverflow.com/questions/32127524/how-to-install-and-use-make-in-windows