search

teal-language / tl

The compiler for Teal, a typed dialect of Lua
MIT License
2.1k stars 108 forks source link

Skip UTF-8 BOM when reading file (#435) #570

Closed sveyret closed 1 year ago

sveyret commented 1 year ago

Closes #435.

sveyret commented 1 year ago

@hishamhm, I don’t think the failing test is caused by my modification. If it is, please tell me. If not, I’d be glad to have a review.

lenscas commented 1 year ago

I think you can update https://github.com/teal-language/tl/blob/602943fa2ef4901c42f27679cbdd135a7066af5c/.github/workflows/playground.yml#L12 to point to node version 14 and have it work.

Seems like some node package got updated and it now requires node 14 instead of 12. Considering that this is error is while building a new playground version and more specifically the node.js parts rather than the lua/teal parts it is indeed not this change that broke things. I would also expect that any other PR will also fail with the same error.

hishamhm commented 1 year ago

@lenscas if you're able, could you push a PR that bumps the node version and confirms that this is the proper fix? otherwise I'll try to do it when I get the time. thanks!!

hishamhm commented 1 year ago

@sveyret Thank you!