tealdeer-rs / tealdeer

A very fast implementation of tldr in Rust.
https://tealdeer-rs.github.io/tealdeer/
Apache License 2.0
4.17k stars 123 forks source link

Release with github workflow #170

Closed black7375 closed 2 years ago

black7375 commented 3 years ago

image Issue: #165

I created a workflow that puts Mac into the release. You don't have to expose the GitHub key.

Here's how to permanently erase files from the Git History:

git filter-branch --tree-filter 'rm -rf ./release-build.sh' HEAD
git filter-branch --prune-empty HEAD
git push origin --force master
black7375 commented 3 years ago

I'll check it out in the evening

black7375 commented 3 years ago

@dbrgn

https://gist.github.com/schell/2fe896953b6728cc3c5d8d5f9f3a17a3 I haven't tested it yet, but it looks good.

dbrgn commented 3 years ago

That looks pretty nice and maintainable!

black7375 commented 3 years ago

First of all, upload is successful.

Are there any changes to the Docker configuration? https://github.com/black7375/tealdeer/runs/2551474861?check_suite_focus=true Code is the same, but build fails.

dbrgn commented 3 years ago

Thanks for the update!

I'm not aware of any changes, but this seems to be an OpenSSL linking issue. OpenSSL will get thrown out by #187, so it's best if we wait until that's merged before finishing this.

dbrgn commented 3 years ago

@black7375 PR #187 is now merged, OpenSSL is no longer a dependency. Could you rebase this PR?

black7375 commented 3 years ago

Successfully executed fetch.

dbrgn commented 3 years ago

@black7375 what does that mean? 🙂 you did not push any changes.

black7375 commented 3 years ago

I ran a fetch updstream on GitHub. Ah. Did you mean to rebase the commit log?

dbrgn commented 3 years ago

Yes, it would be great if you could rebase your master branch against the upstream master branch and push the changes (you'll need git push --force). Then, you could push a new tag to your fork, to test whether the builds now succeed. The last few workflows all failed: https://github.com/black7375/tealdeer/actions

If you need help with rebasing, just let me know, happy to help!

black7375 commented 3 years ago

Yes. I rebase and it all passes.

I don't know why the existing action failed. I have created a separate release-related action, which shouldn't affect the test.

dbrgn commented 2 years ago

Replaced by #240.