Closed sondr3 closed 3 years ago
Updated according to the reviews, I'm on a different computer so can't run the benchmark again but there shouldn't be a difference.
I actually started converting the unwrap
s to proper errors, but figured it was out of the scope of this PR. Happy to fix though, it may take a few days as we are celebrating our Independence Day tomorrow 😄
I think I managed to fix the requested changes, this is ready for another round of reviews.
Done :smiley:
Thanks for the first round of reviews, @niklasmohrin. I'll try to take a look this weekend!
rustls
over dynamically linkedopenssl
.Compared to the benchmark in #129 from the first post (ran
hyperfine --prepare 'sync; echo 3 | sudo tee /proc/sys/vm/drop_caches' './target/release/tldr tar'
). I don't know the exact command that the author ofoutfieldr
ran, but you can also see a comparison I posted there.