Fix clippy warnings - Githubissues

tealdeer-rs / tealdeer

A very fast implementation of tldr in Rust.

https://tealdeer-rs.github.io/tealdeer/

Apache License 2.0

4.17k stars 123 forks source link

Fix clippy warnings #188

Closed dmaahs2017 closed 3 years ago

dmaahs2017 commented 3 years ago

allow struct excessive bools for Args struct.
change tests to use write_all instead of write
allow dead_code for the ConvigVar variant of PathSource

dmaahs2017 commented 3 years ago

@niklasmohrin review please :)

this just fixes clippy --all-targets warnings. They were bothering me.

I wasn't sure if there was a reason for the ConfgVar variant in the PathSource enum. Presumably we will use it in the future. So for now I #allow(dead_code) for it. Otherwise I can just as easily delete it.

Edit: annoyingly the CI clippy check doesn't like the #allow[struct_excessive_bools) annotation, even though it works on my machine fine (Stable toolchain as well as nightly toolchain)

dmaahs2017 commented 3 years ago

Can only agree with @dbrgn, comment seems like a good idea and feel free to bump the rust version in .github/workflows/ci.yaml. Other than that, there's nothing to complain about. Good catch with write_all!

@dbrgn Why do we have MSRV anyway? It's not like we're a library that people depend on, so does it even matter? We could just say "builds on stable, everything else no guarantees"

I'm curious why we run our tests on 1.41.1 as well as on stable

niklasmohrin commented 3 years ago

@dmaahs2017 FYI, further steps with MSRV are currently discussed in #190