search

tealdeer-rs / tealdeer

A very fast implementation of tldr in Rust.
https://tealdeer-rs.github.io/tealdeer/
Apache License 2.0
4.17k stars 123 forks source link

Run clippy on stable with msrv setting instead of on msrv #200

Closed niklasmohrin closed 3 years ago

niklasmohrin commented 3 years ago

I noticed that this setting exists the other day.

Using this, we should always get the newest (and fixed) lints from stable without comprimising msrv. Note that we are still building and testinig on msrv, so we still catch all these errors. :^)

dbrgn commented 3 years ago

Oh, nice. Does this mean that Clippy will show the same results, no matter what local Rust version is installed?

niklasmohrin commented 3 years ago

No, this changes nothing on how rustup determines which version to run. It just tells the version that is used to not lint things that are not possible in 1.52. For example bool::then is enforced by clippy over if { Some(...) } else { None }, but if your msrv is set lower than the version that introduced bool::then it won't complain. This means that we can use recent versions of clippy without it contradicting to msrv build

dbrgn commented 3 years ago

Ah, that's even better 🙂