search

tealdeer-rs / tealdeer

A very fast implementation of tldr in Rust.
https://tealdeer-rs.github.io/tealdeer/
Apache License 2.0
4.17k stars 123 forks source link

Use anyhow #248

Closed dbrgn closed 2 years ago

dbrgn commented 2 years ago

Using anyhow instead of custom error types and strings is probably a good idea.

I started the work to port the codebase to anyhow.

niklasmohrin commented 2 years ago

Lets benchmark afterwards, I am curious

dbrgn commented 2 years ago

What would you benchmark, the error branches? I don't think it should affect the success branches at all (and the error branches don't matter).

niklasmohrin commented 2 years ago

I don't think it should affect the success branches at all

I would expect that too, but I want to be sure 😅

dbrgn commented 2 years ago

Fixed in #249.