search

tealdeer-rs / tealdeer

A very fast implementation of tldr in Rust.
https://tealdeer-rs.github.io/tealdeer/
Apache License 2.0
4.17k stars 123 forks source link

Github Actions: add android.yml to build for Android #263

Closed leleliu008 closed 1 year ago

leleliu008 commented 2 years ago

Signed-off-by: leleliu008 leleliu008@gmail.com

niklasmohrin commented 2 years ago

I must admit, I am not comfortable with cargo-ndk, this just adds too much code to maintain to this repository. In #274, I noted that there is the possibility of using cross which cross-compiles using docker containers. This works great, bat uses it, I use it in another project and it is very easy to use with the actions-rs/cargo action we already use. About the compile error from the issue: We should just remove this function altogether, because the Other variant does not exist anyways

dbrgn commented 2 years ago

In #274, I noted that there is the possibility of using cross which cross-compiles using docker containers.

Does that just build for ARM, or actually on an Android device?

niklasmohrin commented 2 years ago

You can choose any of the rust targets (for example this list), we would probably be most interested in aarch64-linux-android and friends. If I understand it correctly, cross uses a docker container for cross compiling and qemu to run tests - or maybe they also compile in qemu. If we just build without testing, we don't need to worry about any ndk stuff, otherwise, we may have to a little bit of code to hook into that. I don't really know anything about android development, but that's just another reason why I don't want to host these specifics in our repo :D

niklasmohrin commented 1 year ago

@leleliu008 Do you want to continue working on this, or should we close this PR for now?

leleliu008 commented 1 year ago

Since the feature has been implemented in #274, this is no need to go on. Please feel free to close it.