Closed qknogxxb closed 1 year ago
And... It's wired that I didn't find any specific .md
located in my ~/.cache/tealdeer/tldr-pages
is a "new format". In other words, they are all "old format", which means that my contribution code will never run. Anyway, this has nothing to do with this PR, I just mention this here.
Yeah, I am not exactly sure what the idea between old and new format is or if there are any plans for migrating towards one or another. I think we talked about this some time ago, the info is probably buried in some comment somewhere. @dbrgn Do you remember what that was about?
Support for the new format was added here: https://github.com/dbrgn/tealdeer/pull/32
See discussion at https://github.com/tldr-pages/tldr/pull/958
From what I can tell, the new format was never accepted. So I guess we could remove it from tealdeer as well...
Well, thanks for the contribution anyways :)
@niklasmohrin As you mentioned in #314, I improved test functions on
LineIterator
. With your counter example code:The test function will fail:
Do you think this is good enough? Or you have another idea?