readSheetsFromZipFile: fix channel leak

tealeg / xlsx

Go library for reading and writing XLSX files.

Other

5.81k stars 808 forks source link

readSheetsFromZipFile: fix channel leak #768

Closed dolmen closed 1 year ago

dolmen commented 1 year ago

Close channel when work is done successfully.

A few error cases are remaining where the channel is not properly closed. I don't have time to fix them now, but at least they are now properly marked with "FIXME" markers.

ghost commented 1 year ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/tealeg/xlsx/768/b630c040/d1027be15a03e7b9553ee49b9cc587bf5965fb22.svg)](https://app.codesee.io/r/reviews?pr=768&src=https%3A%2F%2Fgithub.com%2Ftealeg%2Fxlsx) #### Legend CodeSee Map legend