tealeg / xlsx

Go library for reading and writing XLSX files.
Other
5.81k stars 808 forks source link

use random file name for RoundTripFileWithNoSheetCols test #773

Closed benedictjohannes closed 10 months ago

benedictjohannes commented 10 months ago

In my test, RoundTripFileWithNoSheetCols fails with error e"OpenFile: open testdocs/after_write.xlsx: no such file or directory" This is most likely due to the parallel test runs called by csRunO that try to write and remove the files concurrently. Failed error attached

By choosing a random filename, each test create/write and removes its own file, allowing this test to pass as expected.

ghost commented 10 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/tealeg/xlsx/773/f58aa7c6/baa8cb3bc41f9afd649e29de2e75438864e5ce83.svg)](https://app.codesee.io/r/reviews?pr=773&src=https%3A%2F%2Fgithub.com%2Ftealeg%2Fxlsx) #### Legend CodeSee Map legend