don't write dump.xml on truncateSheetXMLValueOnly

tealeg / xlsx

Go library for reading and writing XLSX files.

Other

5.85k stars 819 forks source link

don't write dump.xml on truncateSheetXMLValueOnly #774

Closed benedictjohannes closed 1 year ago

benedictjohannes commented 1 year ago

It looks like dump.xml are merely dumping XML rows that are never read back.

As such it is unnecessary and might cause unexpected errors when the program is called in a read-only directory/FS without serving any purpose.

ghost commented 1 year ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/tealeg/xlsx/774/26995a2a/3ff194b2acdce296f467c09560cd8aa6e8844784.svg)](https://app.codesee.io/r/reviews?pr=774&src=https%3A%2F%2Fgithub.com%2Ftealeg%2Fxlsx) #### Legend CodeSee Map legend