Support bool type values on Cell.SetValue()

tealeg / xlsx

Go library for reading and writing XLSX files.

Other

5.81k stars 808 forks source link

Support bool type values on Cell.SetValue() #782

Closed WKBae closed 8 months ago

WKBae commented 9 months ago

Cell.SetValue(bool) sets the cell's value to be a plain string "true"/"false", instead of the expected boolean values, displayed as "TRUE" or "FALSE" on MS Excel. Add the missing bool type case in SetValue to call Cell.SetBool.

ghost commented 9 months ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/tealeg/xlsx/782/9e3d8b58/c7161031dee321a830e2a7d4ecc1dbffa8f8a8bc.svg)](https://app.codesee.io/r/reviews?pr=782&src=https%3A%2F%2Fgithub.com%2Ftealeg%2Fxlsx) #### Legend CodeSee Map legend

tealeg commented 8 months ago

Thanks @WKBae !