search

tealeg / xlsx

Go library for reading and writing XLSX files.
Other
5.81k stars 808 forks source link

fix: TimeFromExcelTime #795

Closed martianwei closed 3 months ago

martianwei commented 5 months ago

issue #793 fix TimeFromExcelTime

ghost commented 5 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/tealeg/xlsx/795/2e89dcbb/9872eb854c0bbccb919987a4d8cdfeae2dd2845c.svg)](https://app.codesee.io/r/reviews?pr=795&src=https%3A%2F%2Fgithub.com%2Ftealeg%2Fxlsx) #### Legend CodeSee Map legend
tealeg commented 5 months ago

It seems this change causes existing tests to fail. This might well be more complicated than adding that offset.

github-actions[bot] commented 3 months ago

Stale pull request message