team-abnormals / atmospheric

Fills the world with fleshed out & diverse landscapes
https://www.curseforge.com/minecraft/mc-mods/atmospheric
Other
75 stars 33 forks source link

Atmospheric & Environmental biomes improperly populate biome features during BiomeLoadingEvent #121

Closed yungnickyoung closed 3 years ago

yungnickyoung commented 3 years ago

This is the same issue as https://github.com/team-abnormals/environmental/issues/225, but it applies to Atmospheric as well:
https://github.com/team-abnormals/atmospheric/blob/main/src/main/java/com/minecraftabnormals/atmospheric/core/other/AtmosphericGeneration.java

Biomes are expected to be fully populated by the time the BiomeLoadingEvent occurs so that other mods can modify them. Populating your own biomes' features during this event prevents other mods from accessing them in the expected manner. The linked issue for Environmental contains a more detailed description, as well as some proposed solutions.