search

team-abnormals / atmospheric

Fills the world with fleshed out & diverse landscapes
https://www.curseforge.com/minecraft/mc-mods/atmospheric
Other
74 stars 32 forks source link

Loading some arid shrines can cause indefinite server/singleplayer lag #197

Closed thelegitdolt closed 1 year ago

thelegitdolt commented 1 year ago

This is a critical issue that deadlocks all chunks around render distance of glitched arid shrines.

One example of this can be found in seed -1312028419313609502 at coord -4000, 7500 using a modpack that I can provide in DMs if needed since it contains caverns and chasms.

After loading a corrupted Arid Shrine, the game stop advancing its ticks, and eventually crashed with this crash report: https://gist.github.com/thelegitdolt/c8227ed7a0f6176e87ec843821ad97ad and this log: https://gist.github.com/thelegitdolt/c229b382aec5872d95d5ef8f7f9e628a (scroll to the bottom for the crash occured). This is the debug.log that was mentioned: https://gist.github.com/thelegitdolt/54ffd6b3c6fad5d0c8bf1309c8c2dd4f

Please fix this as soon as possible as the arid shrines are corrupting our server. Thank you!

thelegitdolt commented 1 year ago

Have confirmed that this lag is caused by arid shrines; the world loads completely fine after preventing arid shrines from generating via emptying the#atmospheric:has_structure/arid_shrine tag.

thelegitdolt commented 1 year ago

https://twitter.com/chorocurus/status/1678622220132687873 might be a false alert actually. I will try to fix the stronghold bug myself tomorrow, and then load some arid shrines to see if the issue is fixed.

thelegitdolt commented 1 year ago

this was definitely caused by the stronghold. my bad