search

team-abnormals / berry-good

Improves berries in simple ways, like placement and usage
https://www.curseforge.com/minecraft/mc-mods/berry-good
Other
24 stars 21 forks source link

Non thread-safe composter registration #6

Closed pau101 closed 4 years ago

pau101 commented 4 years ago

I am reporting to you on behalf of Markus1002/Autumnity/issues/11

Currently Berry Good is registering compostability during the parallel dispatched common setup event. As this event is fired in parallel, multiple mods performing registration at this time create a race condition of whether an internal map corruption will occur, leading to startup crashes as seen in the linked issue. You should register compostability during relevant block/item registry events or utilize DeferredWorkQueue.