search

team-abnormals / blueprint

Library that implements the framework of all Abnormals mods
https://www.curseforge.com/minecraft/mc-mods/blueprint
Other
114 stars 33 forks source link

[1.16.5] Texture Reference Chain Error - With Solution #129

Closed dfontana92 closed 2 years ago

dfontana92 commented 2 years ago

Please fill out the template below to describe your issue. Doing so greatly helps us understand what happened!

Description Texture reference chain errors are thrown when loaded alongside CTM, but the error IS NOT a flaw in CTM as has been claimed on the past several issues opened for this.

The issue stems from the way that unused parent blocks were exported from BlockBench. There are circular (or null, I suppose) references to textures on these ten block models which are all unused in-game and serve only as parents for more specific types of thatch blocks:

Thatch.json Thatch_slab.json Thatch_slab_top.json Thatch_stairs.json thatch_stairs_inner.json thatch_stairs_inner_top.json thatch_stairs_outer.json thatch_stairs_outer_top.json thatch_stairs_top.json thatch_vertical_slab.json

Your reference error is here: "textures": { "thatch": "#thatch", "extrudes": "#extrudes", "particle": "#thatch" },

You should not be trying to evaluate "thatch" and "extrudes" to themselves. Simply remove these lines and the errors are resolved. Thatch blocks in-game are unaffected, as you set these textures appropriate in the child block json (within Environmental mod).

Steps to reproduce: Errors are thrown upon game launch

Expected behavior:

Logs

Screenshots

Mod list: AbnormalsCore CTM

SmellyModder commented 2 years ago

Weirdly, this issue doesn't occur without CTM, but it will get fixed. Your proposed solution is a bit incorrect as not all those lines need to get removed. Removing the particle key would force models extending the thatch models to define the particle key.

dfontana92 commented 2 years ago

Apologies, I suppose it was not 100% clear, but I was only proposing that the "Thatch" and "Extrudes" keys be removed (as you say).

Curiously, in some cases (Farmer's Delight, for example), the Particle key DID have to be moved to the extended models. The ModelBakery was failing to bake the models in that case, as the value assigned to the key did not exist in the parent context.

I have not noticed the same issue with Abnormals Core, but perhaps #thatch exists somewhere else in the model stack.