search

team-abnormals / blueprint

Library that implements the framework of all Abnormals mods
https://www.curseforge.com/minecraft/mc-mods/blueprint
Other
114 stars 33 forks source link

Added createMobBucketItem method #149

Closed Uraneptus closed 2 years ago

Uraneptus commented 2 years ago

This PR adds a createMobBucketItem method to the ItemSubRegistryHelper The method creates and registers a BlueprintMobBucketItem with an EntityType Supplier that extends WaterAnimal.

This PR also adds a Test for this method even though I wasn't sure if that's necessary.

I originally had this method separately in my mod, but since I'm using Blueprint anyways I thought I could create this PR, so others can use it too!

SmellyModder commented 2 years ago

Unfortunately, the new method proposed in this PR is a bit too niche.

This method may be useful to modders who are adding new fish buckets to the game, but it could end up underused if modders want a custom fluid, sound, and/or properties for their fish buckets. Naturally, one could argue that parameters for the fluid, sound, and properties could get added instead, but that would mean the method is just an unnecessary way of creating and registering a BlueprintMobBucketItem.

Uraneptus commented 2 years ago

Yeah I get that, good point!