search

team-abnormals / blueprint

Library that implements the framework of all Abnormals mods
https://www.curseforge.com/minecraft/mc-mods/blueprint
Other
111 stars 34 forks source link

All banner patterns registered by blueprint are available in the loom table even without their respective banner pattern items #163

Closed thelegitdolt closed 1 year ago

thelegitdolt commented 1 year ago
Screen_Shot_2022-07-06_at_6 12 20_PM

(note the chimpanzee, honeycomb, and windswept's snow charge and snow golem patterns in the end)

SmellyModder commented 1 year ago

As I stated in the last issue you opened, Blueprint's BannerManager uses the BannerPattern#create() method provided by Forge, so this is not a Blueprint issue. In 1.19, a tag is used to determine if a banner pattern needs an item in the loom. In 1.18.2, the hasPatternItem boolean is used from BannerPattern.

thelegitdolt commented 1 year ago

should i report this to forge then

SmellyModder commented 1 year ago

In 1.19, a tag is used to determine if a banner pattern needs an item in the loom. In 1.18.2, the hasPatternItem boolean is used from BannerPattern.

No

thelegitdolt commented 1 year ago

i dont understand. Do you mean that Is it the fault of the mods that registering the patterns? but half of the mods are abnormals.

SmellyModder commented 1 year ago

Yes, it's the fault of the mods registering the patterns.