team-abnormals / blueprint

Library that implements the framework of all Abnormals mods
https://www.curseforge.com/minecraft/mc-mods/blueprint
Other
114 stars 33 forks source link

[CRASH, 1.20.1] Incompatible with old versions of Repurposed Structures, Integrated API, Moog's End Structures, and Moog's Nether Structures #226

Closed SmellyModder closed 6 months ago

SmellyModder commented 6 months ago

If you have encountered a crash lately that appears to have been caused by Blueprint and involves RemoldedResourceManager, it may be because of one of the mods mentioned above and not Blueprint's fault.

See https://github.com/TelepathicGrunt/RepurposedStructures/issues/324.

Please use Repurposed Structures versions 7.1.12 and above. Please use Integrated API versions 1.4.1 and above.

The other two mods mentioned in the title still need to fix their issue. See https://github.com/FinnSetchell/MoogsEndStructures/issues/6

Explanation of the issue: If you see a crash that looks like the following with some slight package name differences, it is most likely not Blueprint's fault.

java.lang.ClassCastException: class com.teamabnormals.blueprint.common.remolder.RemoldedResourceManager cannot be cast to class com.finndog.mes.mixins.resources.ReloadableResourceManagerImplAccessor

It appears all the mods mentioned are using Repurposed Structures' method of loading multiple files with the same name/path across all datapacks. However, a mixin is not needed to do this and is entirely possible with vanilla methods. See this commit for proof: https://github.com/TelepathicGrunt/RepurposedStructures/commit/35f9f9acb18ae3ef0ed01fe98d69358e83a81206