team-abnormals / blueprint

Library that implements the framework of all Abnormals mods
https://www.curseforge.com/minecraft/mc-mods/blueprint
Other
114 stars 33 forks source link

Added method that adds item to jigsaw pool #62

Closed flowerfugue closed 3 years ago

flowerfugue commented 3 years ago

I'm planning to use this for a small thing in S&R but I think it would be good for AC as it has other applications - for example, Buzzier Bees also adds to village housing pools using a more situational method.

This PR also renames getStateAtOffsetPos to stateAtOffsetPos and getEntitiesAtOffsetPos to entitiesAtOffsetPos. I felt that the 'get' was a bit redundant.

flowerfugue commented 3 years ago

I reverted the name changes. Is this ready for re-review?

flowerfugue commented 3 years ago

The reason for the change in cb27f94 was that you couldn't use subclasses of Entity, and f5dbd66 was because I found a use case where I needed to check against a predicate at the offset pos.