team-abnormals / blueprint

Library that implements the framework of all Abnormals mods
https://www.curseforge.com/minecraft/mc-mods/blueprint
Other
114 stars 33 forks source link

Abnormals Core possibly breaking desert pyramid loot tables #68

Closed Maltshakes closed 3 years ago

Maltshakes commented 3 years ago

My desert pyramids all have empty loots chests. After installing the Blame mod and attempting once more to open a chest, it pointed me towards Abnormals Core as the cause.

The log from Blame is in the pastebin link below. Line 1300 is what mentions Abnormals Core.

https://pastebin.com/dSEbDn09

Maltshakes commented 3 years ago

This also seems to affect jungle temple loot chests

SmellyModder commented 3 years ago

Abnormals Core is crashing, but it isn't the root of the issue. There's an error with those loot tables happening somewhere caused by another data pack. When this error occurs, it causes the loot table to be null since it couldn't be parsed, and Abnormals Core assumes that the loot table will always be nonnull, as does the forge event. Fixing the error with the table causing it to be null will fix this crash, but I will also look into putting a null check in the event to prevent edge cases like this from happening again.