team-abnormals / upgrade-aquatic

Further upgrades the Update Aquatic with more aquatic additions!
https://www.curseforge.com/minecraft/mc-mods/upgrade-aquatic
Other
157 stars 48 forks source link

Turtle shell durrability drain is disproportianal to air drain #405

Closed Ganpan14O closed 6 months ago

Ganpan14O commented 6 months ago

As the title states it seems the durability loss of the turtle shell has nothing to air drain speed, even while in a bubble column or the aoe of a conduit durability drains, and from this I'd presume that respiration is ineffective too.

bageldotjpg commented 6 months ago

Not sure what your point is, the rework makes turtle shells give water breathing, and durability drain is completely unrelated to the air drain speed, because air wouldn't be draining.

Ganpan14O commented 6 months ago

Not sure what your point is, the rework makes turtle shells give water breathing, and durability drain is completely unrelated to the air drain speed, because air wouldn't be draining.

The issue is that effects such as conduit power and respiration are completely pointless with a turtle shell under this rework as the durability still drains and just as fast. If this is as intended I understand, I just made this as it felt like an unintentional debuff to turtle shells.

bageldotjpg commented 6 months ago

Well yes they don't stack because inherently they work differently but overall the turtle shell is more useful There will be an option to disable the change in the next update

Ganpan14O commented 6 months ago

There is already an option to disable it, it just seems odd that it's fully incompatible with 2 vanilla features that normally synergize well with turtle shells.

Edit: The option is in the config but currently non functional