search

team-charls / charls

CharLS, a C++ JPEG-LS library implementation
BSD 3-Clause "New" or "Revised" License
180 stars 74 forks source link

Fix charls-template.pc #305

Closed bnavigator closed 6 months ago

bnavigator commented 6 months ago

The pkg-config points to the wrong include dir.

Compare

https://github.com/team-charls/charls/blob/f2ff4448c2bd90fb15a1abe0e5d1702da1f8532b/src/CMakeLists.txt#L154

vbaderks commented 6 months ago

Hi Ben,

Users of the CharLS library should include the CharLS header files with: #include <charls/charls.h> An additional subdirectory is used to prevent accidental inclusion of header files that exists in the charls subdirectory but may conflict with header files of other libraries (for example version.h)

Adding chars to the includedir would also mean this option is used by the statement: Cflags: -I${includedir}

bnavigator commented 6 months ago

Understood. Thank you!