search

team-eternity / eternity

The Eternity Engine
http://eternity.youfailit.net/wiki/Main_Page
GNU General Public License v3.0
230 stars 36 forks source link

UMAPINFO issues #607

Closed sink666 closed 7 months ago

sink666 commented 9 months ago

In the latest devbuild of EE, Eternity-x64-4.03.00-pre-1244-g34db96e24, there are a couple of issues with parsing UMAPINFO lumps.

Using the wad Arrokoth as an example, EE will not start because its UMAPINFO lump begins with a comment. If you remove the offending comment, EE will not start because the blocks are formatted in a style it doesn't understand:

//EE doesn't expect this
MAP E1M1
{
    //foo
}

//EE would like this instead
MAP E1M1 {
    //foo
}

The standard does not specify a brace style but the example presents the former as how the map entries ought to look, so I assume this is a bug.

sink666 commented 7 months ago

i was incorrect! it was not working because the UMAPINFO parser did not have block comments. and there are no issues with bracket style