team-eternity / eternity

The Eternity Engine
http://eternity.youfailit.net/wiki/Main_Page
GNU General Public License v3.0
230 stars 36 forks source link

Resolution of 5120x1440 exceeds maximum renderer resolution limit? #626

Closed Meerschweinmann closed 3 weeks ago

Meerschweinmann commented 3 weeks ago

Hello again.

When choosing a video mode of 5120x1440 pixels and renderer resolution "native" EE crashes.

Choosing a video mode of 5120x1440 and a renderer resolution of 5048x1420 pixels EE works.

Going up to a renderer resolution of 5084x1430 works, but sometimes it crashes.

It seems that the resolutions or pixel count in this range are the limit for the renderer.

If it helps. The PC is a Ryzen 8700G with 32GB of RAM.

Btw: I was able to built the latest EE with the FOV fix from today. And hey, automatic FOV works great now. Thank you :)

Meerschweinmann commented 3 weeks ago

Btw. Because EE has the ability to handle 32:9 aspect ratio, it would fine when the aspect ratio selection would contain 32:9. And some resolutions like 2560x720, 3200x900, 3840x1080 and 5120x1440.

Eventually a 4268x1200, even it is not a resolution monitors have, but resolutions with 1200 lines scale well with DOOMs HUD and weapons and the 20% horizontal stretch in mind. I had used downscaled 1200 line resolutions even on my old 1080p monitor to get better non-wobbly weapon pixels.

Me personally knows what my screens resolution is and what alternatives are there as 32:9 aspect ratio.

But it makes EE a bit more userfriendly for users that are not so aware about what they have.

ioan-chera commented 3 weeks ago

Apparently it was an overshooting error caused by coarse approximation. If resolution is 5090 or above, the scale value becomes too small before getting incremented by a flat value (1), so drawing the status bar (etc.) would hit w instead of w - 1 as normal. Fixed.

Meerschweinmann commented 3 weeks ago

Wow, that was fast. Thanks again!