team-exor / eiquidus

Feature-rich open-source altcoin block explorer. Regular Updates ~ Platform Independent ~ Mobile Friendly ~ Supports Themes, Markets, Charts, Claiming Addresses, Public API's, Custom RPC Cmds, Bitcoin, Heavycoin, zk-SNARKs ~ List Masternodes, Network Peers, Top 100 Wallets ~ Built-in Update Script ~ Highly Customizable
https://explorer.exor.io
BSD 3-Clause "New" or "Revised" License
85 stars 185 forks source link

the list of masternodes, lists a maximum of 4388 masternodes #30

Closed luc1anocruz closed 1 year ago

luc1anocruz commented 1 year ago

the list of masternodes, both in the api and in the masternode tab, lists a maximum of 4388 masternodes, and the currency has more than 6 thousand masternodes, I looked in the settings for there was some limit but I did not find anything about it https://i.imgur.com/SxZixOo.png

joeuhren commented 1 year ago

There shouldn't be any limitations in the explorer for masternodes. It just saves whatever the wallet is returning.

Have you changed the api_cmds > getmasternodelist option at all or is it still running the default listmasternodes cmd? Can you confirm that there isn't some type of limitation in the wallet daemon that is only returning a subset of the results when you run that cmd manually from the wallet itself? My guess is that you are maybe only returning the list of enabled masternodes and might need to change the cmd or pass another paramter to return all masternodes.

luc1anocruz commented 1 year ago

There shouldn't be any limitations in the explorer for masternodes. It just saves whatever the wallet is returning.

Have you changed the api_cmds > getmasternodelist option at all or is it still running the default listmasternodes cmd? Can you confirm that there isn't some type of limitation in the wallet daemon that is only returning a subset of the results when you run that cmd manually from the wallet itself? My guess is that you are maybe only returning the list of enabled masternodes and might need to change the cmd or pass another paramter to return all masternodes.

in the wallet cmd it lists all normally, returning ENABLE, ACTIVE and EXPIRED, in the website it lists randomly, a little ENABLE, ACTIVE AND EXPIRED

joeuhren commented 1 year ago

which coin is this for?

luc1anocruz commented 1 year ago

my cmd is kicksoccer-cli listmasternodes

coin is KSOC Sports I tried changing the getmasternodelist command in the settings to listmasternodes but it gives an error

Unknown setting 'api_page.public_apis.ext.listmasternodes' has been ignored. This setting doesn't exist or was removed. setting 'api_page.public_apis.ext.getmasternodelist' is missing. Loading default value.

Ignore, is correct in settings, look // getmasternodelist: Returns a json array containing status information for all masternodes on the network "getmasternodelist": "listmasternodes",

luc1anocruz commented 1 year ago

I think it's a limitation of the explorer, because if it were the cmd, it wouldn't list any, and it's listing both ENABLE and ACTIVE or EXPIRED, only with a maximum limit of 4388. https://i.imgur.com/o8ULcL9.png

joeuhren commented 1 year ago

You're right, it was a problem with the explorer in this case. The issue was that there are certain transactions in the KOSC Sports blockchain where there are hundreds of masternodes created off the same txid and the explorer was expecting each masternode to have a unique txid. This was causing all the other MNs with the same txid to update the 1st record instead of adding a new record.

I've released a small fix to correct this shortcoming. Either run the built-in updater with npm run update-explorer or else you can manually merge the update from here: https://github.com/team-exor/eiquidus/commit/e5bd30a457ff0121fc036fdf3cb960d431ef55a5

Update your explorer code and try syncing masternodes again. Let me know how it goes.

luc1anocruz commented 1 year ago

Perfect! update tested and approved, now loads all masternodes, thanks for the great job to this excellent explorer.