Adjust allowed attributes for the `many`

team-formalist / formalist-rb

Flexible form builder

MIT License

22 stars 4 forks source link

Adjust allowed attributes for the `many` #35

Closed makenosound closed 8 years ago

makenosound commented 8 years ago

Removes the various allowed_ attributes and adds some simple display attributes.

timriley commented 8 years ago

This looks fine to me. I just wish I could think of a better name for add_label :weary:

Elsewhere in formalist, we have a lot of plain label attributes, and selector_label. add_label feels funny to me here because it could be mistaken as a verb.

creation_label? item_addition_label? action_label? add_action_label? add_button_label? (though I know we've tried to make the attributes not too UI-implementation-specific in the past)

makenosound commented 8 years ago

action_label seems reasonable to me. I’ll adjust.

timriley commented 8 years ago

Cool. Happy for you to merge!

makenosound commented 8 years ago

I’m doin’ it, I’m doin’ it.