search

team-formalist / formalist-rb

Flexible form builder
MIT License
22 stars 4 forks source link

Correctly render links marked as `newWindow` #61

Closed makenosound closed 7 years ago

makenosound commented 7 years ago

Checks for the presence of the newWindow attribute in the link and renders the appropriate additional attributes, so we end up with:

<a href="/foo" target="_blank" rel="noopener">...

See https://mathiasbynens.github.io/rel-noopener/ for detail on rel="noopener".

makenosound commented 7 years ago

@andrewcroome @tobydallder This fixes the issue with "Open in new window" not being reflected in the rendered output from formalist. @andrewcroome If this look alright to you, mind merging this and updating USSC?

andrewcroome commented 7 years ago

I've confirmed that this is working in USSC.