Review 9: AddProfile.jsx

[silviadebenedictis]

Overview

The focus for this code review will be centered around the Add Profile page.
Please pay attention too:

• Javascript issues
• React components

Review Branch

review-xxx

Files to review

• AddProfile.jsx

Checklists

• Architecture
• Design
• JS
• React
• Testing

Due date

Monday, April 1st 11:55pm

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

[silviadebenedictis]

AddProfile.jsx

• ES-01: L31 ESLint: 'A space is required before '}'.(object-curly-spacing)'
• JS-07: Avoid console.logs

[gavyngostage]

AddProfile.jsx

• ES-01: L31 ESLint: 'A space is required before '}'.(object-curly-spacing)'
• JS-07: Avoid console.logs, this can cause flooding to the console and with enough even slow down performance

[zhuochenggan]

AddProfile.jsx Consider adding check to avoid duplicate profile? JS-07: Avoid console.logs

[joelvanta]

AddProfile.jsx

• UserProfileCollection does not add a profile for the user.
• Ensure the formatting of the ProfileCardDisplay matches with the UserProfile.jsx

[ThanhLy1]

• Ref Management: Convert the formRef initialization to use React's useRef hook for better ref handling in functional components.
• User Data Access: Implement checks for null values when accessing Meteor.user().username to avoid runtime errors if the user is not loaded.
• Role Default Value: Simplify management by keeping the default value for role in one place, preferably in the schema, to avoid inconsistency.
• Prop Validation: Add prop validation to enhance component reliability and maintainability, especially if more props are to be used in the future.
• Error Handling: Improve error handling in the Meteor method callback to manage UI state properly in case of errors.
• Navigation Safety: Ensure that redirects after asynchronous operations check if the component is still mounted to prevent React state update warnings.