Review 2: Calendar, Add Nonprofit & Chat

[mikhail-shkaralevich]

Overview

The focus for this code review will be centered around the Calendar, Add Nonprofit & Chat pages.
Please pay attention too:

• Javascript issues
• React components

Review Branch

review-02

Files to review

• Calendar folder
• AddNonprofit.jsx
• Chat.jsx

Checklists

• Architecture
• Design
• JS
• React
• Testing

Due date

Wednesday, February 5th

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

[mikhail-shkaralevich]

Suggestions from a Discord meeting with the team:

Calendar:

• Add a filter, to switch between all events and the ones a user is registered for.

Nonprofit:

• 3 collections or just one collection with optional fields.

Chat:

• Make it pop up in the screen instead of using a separate page for it

[silviadebenedictis]

Add Nonprofit

• ESLINT-01: L3 'NumField' is defined but never used.

Calendar

• Design-05: Large comment blocks

• Consider adding error handling for the subscription, especially when fetching events from the database.

[joelvanta]

Add Nonprofit

ESLINT-01: NumField not used Design-03: ’Location’ is part of the collection but does not show up in the page Design-03: ‘Picture URL’ in the TextField does not show up in the page

Chat.jsx

Meteor-04: Do we have a collection for the chat in order for it to be received and sent?

[zhuochenggan]

Add Nonprofit ESLINT-01: NumField not used Design-05: Ensure comments are appropriate, remove comment for add stuff and change to add non profit

Calendar: Design-04: Eliminate large comment blocks.

[mnakagawa14]

Calendar Folder:

EventCollection.js AR-02 Should it be in the calendar folder? It looks like it has info that will be used elsewhere. Maybe create a separate event folder.

AddNonprofit.jsx ESLINT-01: NumField not used

[gavyngostage]

1. EventCollection.js AR-02: Consider relocating the EventCollection.js file to a more suitable location, as it appears to contain information that may be used beyond the calendar functionality. Perhaps creating a separate "event" folder could enhance code organization and maintainability.

2. AddNonprofit.jsx ESLINT-01: The NumField component is defined but not utilized within the AddNonprofit.jsx file.

3. Chat.jsx: Meteor-04: Ensure that a collection exists for the chat functionality to enable message reception and sending. Redesign: Make chat a pop-up on the side of any page instead of its own screen