Review3: Schemas and PropTypes

[mikhail-shkaralevich]

Overview

The focus for this code review will be centered around structure and organization of schemas and propTypes in the project. For better re-usability and maintenance, we should consider storing all our schemas and propTypes in one location.

Please pay attention to:

• Code organization.
• File structure.

Review Branch

review-70

Files to review

• PropTypes.js,
• DBSchemas.js.
• FormSchemas.js

Checklists

• Architecture
• Design
• JS
• React
• Testing

Due date

12, February 11:55pm

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

[joelvanta]

DBSchemas.js

JS-01: allowedValues in the type should be [Charitable, Church/Religious, Private Foundations, Political Organization, Other] 'mission' can be omitted 'location' can be named as address of the organization to avoid confusion add contactPerson with contactInfo

PropTypes.js

JS-01: 'mission' can be omitted 'location' can be named as address of the organization to avoid confusion add contactPerson with contactInfo

[mikhail-shkaralevich]

/propTypes

AR-01: /propTypes directory should be written /prop-types.

DBSchema.js

The Collection should be split into 2: Organization & Individual. JS-01: type should be updated with new values or removed.

PropTypes.js

JS-01: Update the propType in accordance with DBSchema.js

[silviadebenedictis]

PropTypes.js

JS-01: What does 'location' refer to: the organization's or event's location?

DBSchemas.js

JS-01:

• What does 'location' refer to? Add a better descriptive name

• L6 what's the difference between 'Business' and 'Organization'?

JS-08: Add some comments to avoid confusion

[mnakagawa14]

PropTypes.js JS-01: Mission should be clarified. Nonprofits may have multiple missions. Is it a description of the nonprofit?

DBSchemas.js JS-01: What is the difference between Business and Organization? Mission should be clarified (same as above). Should an Individual have a mission?