search

team-inbox / inbox-reborn

Web Extension which brings back the style and features of Google Inbox to Gmail™
https://team-inbox.github.io/inbox-reborn
MIT License
42 stars 10 forks source link

Compose button misbehaving #20

Closed jarekwg closed 3 years ago

jarekwg commented 3 years ago

Compose button has migrated to the LHS of the page. image

Seems latest gmail has moved the button, and unlinked it from inbox-reborn's compose button in the bottom right.

e: for reference, here's what it looks like skinless: image

jonrandy commented 3 years ago

Hmmmm... not for me it hasn't - on neither of my 2 accounts. Maybe they're AB testing an upcoming change. I guess we'll need to fix stuff if changes over completely

jarekwg commented 3 years ago

Hmm, yeah I'm not seeing it on my other gmail account.. fun!

joeytroy commented 3 years ago

Nor me?

joeytroy commented 3 years ago

@jarekwg can you try and install from the Google Chrome Store and see if it happens again?

https://chrome.google.com/webstore/detail/inbox-reborn-theme-for-gm/bkphmihkdbdgedlaflnkhnmnmibffomf

jarekwg commented 3 years ago

Ooh, nice to see it's back in the chrome web store!

But nope, 0.5.9.2, doesn't address this either. Working compose button is still in the top left, with both extension enabled and disabled. This theme's big red compose button in the bottom right gets rendered, but is not functional. Blue reminder button above it doesn't do anything either.

joeytroy commented 3 years ago

@jarekwg what browser are you using?

jarekwg commented 3 years ago

Chrome, Version 90.0.4430.72 (Official Build) beta (x86_64) I have work and person gmails open in two separate tabs -- one has the compose button shifted to top left, other has it in bottom right (and works with inborn theme). As you said, this is likely some AB testing, but happy to give you more info if you need.

joeytroy commented 3 years ago

@jarekwg What if you install the standard version of Chrome and not the beta? This is the version I am running on my Mac, and Windows box.

90.0.4430.85 (Official Build) (x86_64)

joeytroy commented 3 years ago

@jarekwg One other thing to check is what version of Gmail they are loading you. If you turn off the extension through chrome://extension and then inspect the page look at the following section of code, I am guessing this is the version of Gmail I have, I wonder if yours is different?

image

jarekwg commented 3 years ago

hrm, data-new-gr-cs-s-loaded isn't present in the source. The block you're referring to exists, and all of its other keys are present, except that one. Further, what is present, is identical between my two tabs.

<body
  jscontroller="hS6RLb"
  jsmodel="utMpr"
  jsaction="rcuQ6b:rcuQ6b;A59Jsf:aeO1Sd;RW0A4:WBopzd;FwQykc:k0aXUd;LPBdz:LCjO0c;jrvfrd:PB0Csf;FGHbk:Nx2Sl;qNGYPc:LEY81c;JpvSPb:EL4Jr;Aeulrb:nixEK;YweIdb:.CLIENT;iE7Vzc:.CLIENT;v9KJX:.CLIENT;RzaMQe:.CLIENT;Jdbq1c:.CLIENT;IRuwXc:.CLIENT;ORuuO:.CLIENT;Ly2fm:.CLIENT"
  class="aAU"
  jslog="38365; u014N:xr6bB; 16:WzZd"
  data-awr-sg-installed="true"
>
joeytroy commented 3 years ago

@jarekwg I assume you also update Chrome? What if you use Edge just for giggles?

jarekwg commented 3 years ago

There's been a new development: My other mail tab has also migrated the compose button to the top left now. I'm guessing they're broadening the rollout? Or it's a caching game.

Dunno about edge (I'm on osx), and only version of Chrome I've been running is that beta version i described above. I just had a look on firefox now though and both my gmails have the compose button in the top left too.

joeytroy commented 3 years ago

@jarekwg Sounds like Google is rolling something else out we may need to deal with it when it comes. Believe it or not, you can install Edge on OSX 🤣 of course it's still just Chrome just MS's baby.

arormoser commented 3 years ago

I'm having the same problem image

joeytroy commented 3 years ago

@arormoser we are aware of the issue but it's not affecting all users yet so I don't know how easy it will be to implement a temp fix. Since I don't see the issue I can't test the code against it. It looks like only a handful of users are getting updated to a new rollout of Gmail and until it affects one of the developers we won't' be able to fix it.

gdubja commented 3 years ago

@g60madman this started last week for me but i thought you guys would be on top of it. i have one of the oldest gmail accounts which is why this stuff normally gets pushed out to me before others. my wife isn't seeing it yet.

strangely, they abandoned hangouts yesterday and replaced it with "chat." and it doesn't behave as nicely in this extension anymore. i can't pop out a chat into its own window any longer.

gdubja commented 3 years ago

oh, and they also updated the icons

image

gdubja commented 3 years ago

and now they've removed the grouping of the email by date: today, yesterday, earlier this week, earlier this month, april, last year, etc. it's just one solid block. image

deepfriedfilth commented 3 years ago

@g60madman @jonrandy you can (temporarily) opt in to the new chat via Settings > Chat and Meet > Chat > Google Chat and you'll be able to see the new compose button near the top of the left side bar...

I've begun messing around in dev tools to simply reposition, but it might require a little bit of R&D to remedy, at least more than I have the effort to dig into immediately 😴

Also want to note that bundling is still working as it should after switching for me, ~and the icons seem unaffected.~ ¯\_(ツ)_/¯

Edit: New icons are present when you select an email. Still pretty legible/usable with the new design, though.

joeytroy commented 3 years ago

@deepfriedfilth yup see the issue now with the settings. I will see if I can take some time to mess with it. Been really busy as work is getting back to normal.

drafie commented 3 years ago

Same issue here - compose button no longer works, seems directly related to the Chat feature for me.

arormoser commented 3 years ago

Any news?

mikeannaj commented 3 years ago

I'm also have the same issue with the lower right hand compose button not operating at all (nor the remind button)

thanks for the hard work on this. Still miss inbox but this gets me pretty close.

deepfriedfilth commented 3 years ago

Quick n dirty solution (Firefox only ATM) until I get s'more sleep and clean up a few things on my dev branch: https://github.com/deepfriedfilth/inbox-reborn/commit/48ad4f25c685cf8ebff35207047aeeb90e91570b

I'll submit a proper PR when I feel it's there!