search

team-leevio / happy-elementor-addons

HappyAddons is a collection of slick, powerful widgets that works seamlessly with Elementor page builder
https://happyaddons.com
GNU General Public License v2.0
0 stars 1 forks source link

Adding prop named `Vue` to window object breaks all menus in All in One SEO due to conflict #12

Open arnaudbroes opened 3 years ago

arnaudbroes commented 3 years ago

Describe the bug

AIOSEO dev here.

The latest version of HEA breaks all menus of All in One SEO (AIOSEO). This is happening because HAE is setting a prop called Vue to the window object and doing so breaks one of AIOSEO's dependencies (vue-scrollto to be precise).

I'd recommend using a more unique prop name so that it doesn't conflict with other plugins/packages.

Feel free to reach out to me if needed.

To Reproduce

Steps to reproduce the behavior:

  1. Install the latest versions of HAE and AIOSEO.
  2. Go to one of AIOSEO's menu pages.
  3. The page will be blank. Check the JavaScript console for errors.

Expected behavior

The menu pages should load just fine.