search

team-phoenix / Phoenix

A multi-system emulator and library manager designed to be both powerful and easy to use.
http://phoenix.vg
GNU General Public License v2.0
377 stars 39 forks source link

Stop including a deprecated header that has been removed in current QT versions #330

Closed drewwalton19216801 closed 7 years ago

drewwalton19216801 commented 7 years ago

https://bugs.archlinux.org/task/52956

Self-explanatory.

athairus commented 7 years ago

Duplicate of #329.

We do not include qtmultimediadefs.h in our codebase: https://github.com/team-phoenix/Phoenix/blob/master/frontend/cpp/frontendcommon.h#L12

The assessment Mr. Rojas made is wrong. There's nothing we can do about this from downstream, the issue is upstream. There was a packaging error caused by that deprecated header being present. It was fixed in the commit linked in that page and will appear when 5.8.1 is released.

Workaround is to ~wait for 5.8.1 to be released~, build 5.8.1 yourself or use 5.9. Either way, Phoenix won't build at all with 5.8.0 on any OS, I've tested this myself.