team-propra / roommate

A project created as part of the module "Programmierpraktikum 2" at Heinrich Heine University Düsseldorf
2 stars 0 forks source link

95 items addnew remove feature #111

Closed themassiveone closed 8 months ago

themassiveone commented 9 months ago
nighoge commented 9 months ago

regarding the last checkbox (delete items entirely works): i think roomDetails.html is not the right place for deleting items from the repository. Thus I would propose that I create a separate page you can access from the homepage where you can see all items. There you can also create new items and delete them (globally).

This page would just be accessible by admins and can later be used to edit/create rooms and the workspaces (deut. Arbeitsplätze) within them.

themassiveone commented 9 months ago

regarding the last checkbox (delete items entirely works): i think roomDetails.html is not the right place for deleting items from the repository. Thus I would propose that I create a separate page you can access from the homepage where you can see all items. There you can also create new items and delete them (globally).

This page would just be accessible by admins and can later be used to edit/create rooms and the workspaces (deut. Arbeitsplätze) within them.

I agree, that´s a good idea @nighoge. I will create a separate issue for it and remove the checkbox from this pr

nighoge commented 8 months ago

After merging the developer's changes with those from the database, the functionality to add and remove items from a room has ceased to work. Upon attempting to debug the process, we observed an unexpected redirection to a Spring-generated class called CglibAopProxy after passing through the booking application service. From there, the execution flow abruptly halts, and there is no further interaction with the RoomDomainService. This behavior was not present prior to the merge, leading to uncertainty about whether altering the security configuration, as suggested in this Stack Overflow thread, is advisable.

Given the absence of any exceptions or warnings, it is unclear what is expected from us by this class.