search

team-supercharge / ShimmerLayout

DEPRECATED - Memory efficient shimmering effect for Android applications by Supercharge.
Apache License 2.0
2.52k stars 282 forks source link

ConstraintLayout Support #73

Open yeminnhtut opened 5 years ago

yeminnhtut commented 5 years ago

Currently, Shimmer Layout extends from FrameLayout.

So, if I am using ConstraintLayout, I need to wrap every component that I want to Shimmer into ShimmerLayout which I believe is not a good implementation as it increases layout hierarchy.

I believe it'd also be helpful for other devs using the library along with ConstraintLayout.

Thanks for the awesome library.

Cheers 🍻

veghtomi commented 5 years ago

Hi @ymhtut, thanks for the feature idea, it sounds really useful. I will put it on my agenda!

kuFEAR commented 5 years ago

Or move the shimmer logic into a delegate, like in library for ability to combine few features in one ViewGroup