search

team-supercharge / nest-amqp

Nest AMQP 1.0 module - NPM package: https://www.npmjs.com/package/@team-supercharge/nest-amqp
https://supercharge.io
MIT License
26 stars 13 forks source link

no support for filters in listener #49

Closed solidhtp closed 2 years ago

solidhtp commented 3 years ago

Hello,

ActiveMQ supports filters by JMS selector expressions or XPath. rhea supports message filtering as described here. @Listen accepts only string type in source.

@Listen(source: string, options: ListenOptions)

In order to support filters source should be type of string | Source Source as described in this line. I tried it locally with type Source and filters were working fine.

I can create a PR which simply changes the source type from string to string | Source.

raschan commented 3 years ago

Hi @solidhtp ,

Awesome, a PR would be welcomed.

solidhtp commented 3 years ago

@raschan PR created. Please merge.

raschan commented 2 years ago

Hi @solidhtp

Sorry for the delay, life happened....

I've updated the package with support for the Source object defined in rhea-promise