Respect the Rx contract for unsubscriptions, make observables lazily evaluated

team-supercharge / rxsnappy

RxSnappy is a thread safe rxjava wrapper for the great SnappyDB fast key-value database for Android.

Apache License 2.0

49 stars 9 forks source link

Respect the Rx contract for unsubscriptions, make observables lazily evaluated #2

Closed pakoito closed 8 years ago

pakoito commented 8 years ago

Using Observable.create() requires respecting several principles about unsubscription and backpressure that this library is not respecting. Apply these principles instead:

https://www.reddit.com/r/androiddev/comments/3u5w0c/if_you_are_writing_observablecreate_theres_a_big/

richardradics commented 8 years ago

Thanks for your feedback! I'm going to start implement this.

pakoito commented 8 years ago

Fixed on 0.2