search

team-telnyx / telnyx-dotnet

.NET SDK for the Telnyx API
MIT License
9 stars 9 forks source link

Fix MDR fields so that it matches API v2 spec #5

Closed yiumingtelnyx closed 3 years ago

thedonmon commented 4 years ago

Gotcha sorry to duplicate those comments

d-telnyx commented 3 years ago

@thedonmon / @yiumingtelnyx is this current ?

thedonmon commented 3 years ago

@thedonmon / @yiumingtelnyx is this current ?

I don't believe so, need to double check the contracts for this object.

Actually I just checked, looking at the OpenAPI Spec the question is whether these docs need to be updated: https://developers.telnyx.com/docs/api/v2/messaging/Messages As To and From are supposedly just strings in OpenAPI? But the docs show they are objects

But it looks like these both do the same thing? https://github.com/team-telnyx/telnyx-dotnet/blob/master/src/Telnyx.net/Services/Messaging/Messaging/MessageService.cs https://github.com/team-telnyx/telnyx-dotnet/blob/master/src/Telnyx.net/Services/Messaging/Messaging_Sender_Ids/MessagingSenderIdService.cs