search

team-telnyx / telnyx-node

Node SDK for the Telnyx API
https://developers.telnyx.com/docs/api/v2/overview
MIT License
54 stars 20 forks source link

Calls.js: support the `streaming_start` and `streaming_stop` commands #139

Closed slapierre closed 1 year ago

slapierre commented 2 years ago

Feature request: add the streaming_start and streaming_stop commands in the CALL_COMMANDS array of Calls.js.

Proposal: opened PR #140.

We forked the telnyx-node repo to add the commands and then modified our app using the Call Commands documentation, we were able to successfully stream the media from a call.

I noticed 2 issues with the build:

  1. ESLint reports a double-quoted string in express.js: can be fixed easily with npm run lint -- --fix

  2. The GitHub CI fails to run:

For item (2) I am experiencing the same output as in the GitHub Action when trying to run npm test locally -- note that I followed the instructions in the README.md to install and run Prism.

ADandyGuyInSpace commented 1 year ago

This should be implemented in the newest update

The quoting error should be resolved as well in the latest update. Start another issue if there's anything else, thanks for your feedback from above! (The tests should also now work correctly)