team-telnyx / telnyx-ruby

Telnyx API Ruby Client
https://developers.telnyx.com/docs/api/v2/overview
MIT License
24 stars 17 forks source link

adding verify_profile_id to fix breaking api change #79

Closed maks112v closed 1 year ago

maks112v commented 2 years ago

Resolves

Deprecation notice: `verify_profile_id' is now a mandatory field. The sunset date for this change is 2022-04-02 00:00:00.

I added support for verification profile param and passed it to the post request body as per the docs. I added it to tests also

maks112v commented 2 years ago

@JZebra The semicolon was resolved and updated with main. Is it possible to get this merged in?

maks112v commented 2 years ago

@JZebra can we get this merged in soon?

andypeters commented 1 year ago

I pinged the Telnyx team on their Slack about this pull request yesterday. They were very happy it was brought to their attention and mentioned prioritizing merging it. I'm using your fork @maks112v and verification API works for me now FWIW.

🤞🏻 it gets merged soon.