team-telnyx / webrtc

SDK for Telnyx's WebRTC platform
https://developers.telnyx.com/docs/v2/webrtc
MIT License
40 stars 19 forks source link

Impossible to install #307

Closed taf2 closed 1 year ago

taf2 commented 1 year ago

installation fails:

 npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: @telnyx/webrtc@2.9.0
npm ERR! Found: eslint@8.14.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^8.3.0" from @telnyx/webrtc@2.9.0
npm ERR!   packages/js
npm ERR!     @telnyx/webrtc@2.9.0
npm ERR!     node_modules/@telnyx/webrtc
npm ERR!       workspace packages/js from the root project
npm ERR!       1 more (@telnyx/react-client)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^5.0.0 || ^6.0.0 || ^7.0.0" from @typescript-eslint/parser@3.10.1
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   dev @typescript-eslint/parser@"^3.6.1" from @telnyx/webrtc@2.9.0
npm ERR!   packages/js
npm ERR!     @telnyx/webrtc@2.9.0
npm ERR!     node_modules/@telnyx/webrtc
npm ERR!       workspace packages/js from the root project
npm ERR!       1 more (@telnyx/react-client)
npm ERR!   peer @typescript-eslint/parser@"^3.0.0" from @typescript-eslint/eslint-plugin@3.10.1
npm ERR!   node_modules/@typescript-eslint/eslint-plugin
npm ERR!     dev @typescript-eslint/eslint-plugin@"^3.6.1" from @telnyx/webrtc@2.9.0
npm ERR!     packages/js
npm ERR!       @telnyx/webrtc@2.9.0
npm ERR!       node_modules/@telnyx/webrtc
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/taf2/.npm/_logs/2023-05-19T12_46_31_509Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/taf2/.npm/_logs/2023-05-19T12_46_31_509Z-debug-0.log
RJSkorski commented 1 year ago

Hi @taf2 ,

to better understand your issue and investigate, can you help us and provide an answer to the following questions:

taf2 commented 1 year ago

@RJSkorski i figured out if i run yarn install instead of npm install things worked. Might be good to add this to the docs...

taf2 commented 1 year ago

I just did the following:

git clone https://github.com/team-telnyx/webrtc.git
cd webrtc
npm i

looks like running yarn install instead works,

Still it's unclear after that how to get a compiled version of the javascript to use via a script tag...

DeividVeloso commented 1 year ago

Hello, @taf2 after installation you need to navigate to the packages/js folder and run yarn build. It will generate a folder with a compiled version called package/js/lib/bundle.js

taf2 commented 1 year ago

Might recommend using github releases in the future that would avoid the need to build or install with npm vs yarn and have any extra dependencies other then click and download... etc... easier to adopt.