PubspecBuilder prints a warning, when it's unable to use git. However, this caused Linux build to silently fail to populate the ref value used for UpgradeWorker to determine whether application's upgrade is available or not.
Solution
This PR refactors PubspecBuilder to throw Exceptions instead of printing a warnings, when git isn't available.
The only downside is longer execution of checkout step: it'll grow from 1-2 seconds up to 5-10 seconds for each job, because GitHub Runner will have to fetch the whole Git history instead of only the branch it's on.
Synopsis
PubspecBuilder
prints a warning, when it's unable to usegit
. However, this caused Linux build to silently fail to populate theref
value used forUpgradeWorker
to determine whether application's upgrade is available or not.Solution
This PR refactors
PubspecBuilder
to throwException
s instead of printing a warnings, whengit
isn't available.The only downside is longer execution of
checkout
step: it'll grow from 1-2 seconds up to 5-10 seconds for each job, because GitHub Runner will have to fetch the whole Git history instead of only the branch it's on.Checklist
k::
labels applied