search

team113 / messenger

Open-source front-end part of messenger by team113
GNU Affero General Public License v3.0
19 stars 15 forks source link

Properly format file attachment sizes (#603) #1115

Closed Gieted closed 2 months ago

Gieted commented 2 months ago

Resolves #603

Synopsis

To do: display file size in properly formatted size units, and cover the formatter with unit tests. ## Solution I'll implement some logic which chooses the right translation for the given file size. ## Checklist - Created PR: - [X] In [draft mode][l:1] - [X] Name contains issue reference - [x] Has type and `k::` labels applied - Before [review][l:4]: - [x] Documentation is updated (if required) - [x] Tests are updated (if required) - [x] Changes conform [code style][l:2] - [x] [CHANGELOG entry][l:3] is added (if required) - [x] FCM (final commit message) is posted or updated - [x] [Draft mode][l:1] is removed - [x] [Review][l:4] is completed and changes are approved - [x] FCM (final commit message) is approved - Before merge: - [x] Milestone is set - [x] PR's name and description are correct and up-to-date - [x] All temporary labels are removed [l:1]: https://help.github.com/en/articles/about-pull-requests#draft-pull-requests [l:2]: /CONTRIBUTING.md#code-style [l:3]: /CHANGELOG.md [l:4]: https://help.github.com/en/articles/reviewing-changes-in-pull-requests