search

team178 / 2016RobotCmdBased

2 stars 0 forks source link

Never ending AutoDrive #26

Open gisellegk opened 8 years ago

gisellegk commented 8 years ago

https://github.com/team178/2016RobotCmdBased/blob/WaterburyCompetition/src/org/usfirst/frc/team178/robot/commands/AutoDrive.java

protected boolean isFinished() {
        return false;
    }

Should probably end at some point. Probably.

nandantumu commented 8 years ago

It doesn't need to end. If we properly wrap it in a command group with a timeout, we should be a-ok. On Mar 7, 2016 2:29 PM, "Giselle" notifications@github.com wrote:

https://github.com/team178/2016RobotCmdBased/blob/WaterburyCompetition/src/org/usfirst/frc/team178/robot/commands/AutoDrive.java

protected boolean isFinished() { return false; }

Should probably end at some point. Probably.

— Reply to this email directly or view it on GitHub https://github.com/team178/2016RobotCmdBased/issues/26.

gisellegk commented 8 years ago

@nt1st Wrapping in a commandgroup adds an extra class, not sure if it's necessary if we're only using one command (we asked Beta and they said don't wrap their commands...)

barrontim commented 8 years ago

FYI ERG uses command groups for all autonomous mode and has the last three years successfully. BUT they also do put something in isFinished ( the default I think ) for all commands in the group. Additionally Betas autonomous never ran once during the competition so I would not trust them that much. The mentor from NRG Michele Cyr is a reliable resource.

Tim

On Monday, March 7, 2016, Giselle notifications@github.com wrote:

@nt1st https://github.com/nt1st Wrapping in a commandgroup adds an extra class, not sure if it's necessary if we're only using one command (we asked Beta and they said don't wrap their commands...)

— Reply to this email directly or view it on GitHub https://github.com/team178/2016RobotCmdBased/issues/26#issuecomment-193435948 .

Tim Barron Computer Science Teacher Farmington High School Farmington Public Schools E: barront@fpsct.org W: 860 673 2514 x2320 C: 860 985 7035

Co-Head Coach of Farmington HS FIRST Robotics Competition Team 178 2013 FIRST Woodie Flowers Award Finalist UTC CT Regional

The documents accompanying this fax or e-mail transmission, including any attachments, are for the sole use of the intended recipients and MAY contain confidential school, health or other information that is legally privileged. The authorized recipient of this information is prohibited from disclosing this information to any other party unless required or permitted to do so by law or regulation.

If you are NOT the intended recipient you are hereby notified that ANY disclosure, copying, or further distribution of the contents of these documents is prohibited. If you have received this information via facsimile in error, please notify the sender immediately and arrange for the return or destruction of these documents. If information is received via e-mail and you are not the intended recipient, please contact the sender by e-mail immediately and delete/destroy both the original and the reply e-mail message.